Thanks for the patch. Usually we append Œdatapath-windows: Brief description¹ for Windows datapath commmits.
Had a comment which is inlined. Thanks, Sairam On 10/5/16, 2:33 PM, "Shashank Ram" <[email protected]> wrote: >@Switch.c: Modifies OvsActivateSwitch() function >to mark the switch as activated only if the >the status is success. The callers itself >only call this method when the isActivated >flag is unset. > >Signed-off-by: Shashank Ram <[email protected]> >--- > datapath-windows/ovsext/Switch.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/datapath-windows/ovsext/Switch.c >b/datapath-windows/ovsext/Switch.c >index 825fa3c..7913cd5 100644 >--- a/datapath-windows/ovsext/Switch.c >+++ b/datapath-windows/ovsext/Switch.c >@@ -556,7 +556,6 @@ OvsActivateSwitch(POVS_SWITCH_CONTEXT switchContext) > OVS_LOG_TRACE("Enter: activate switch %p, dpNo: %ld", > switchContext, switchContext->dpNo); > >- switchContext->isActivated = TRUE; > status = OvsAddConfiguredSwitchPorts(switchContext); > > if (status != NDIS_STATUS_SUCCESS) { >@@ -573,7 +572,7 @@ OvsActivateSwitch(POVS_SWITCH_CONTEXT switchContext) > } Sai: You can add switchContext->isActivated = TRUE; before the cleanup label. This way you can get rid of the check for status==NDIS_STATUS_SUCCESS. > > cleanup: >- if (status != NDIS_STATUS_SUCCESS) { >+ if (status == NDIS_STATUS_SUCCESS) { > switchContext->isActivated = TRUE; > } > >-- >2.6.2 > >_______________________________________________ >dev mailing list >[email protected] >https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma >n_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dc >ruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=JEXx0nmOWA23mhKMOcUJzNcIULZ8kH >WeAtQcmFjGo6k&s=5tUWl0geJxE6uBwW6svE_7kChh5iUVlo8kVnpFUrZSA&e= _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
