> On Oct 19, 2016, at 10:01 AM, Joe Stringer <j...@ovn.org> wrote: > > On 14 October 2016 at 07:37, Bhanuprakash Bodireddy > <bhanuprakash.bodire...@intel.com> wrote: >> Aligning the 'keys' array seems to have positive performance impact. >> >> Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> >> Co-authored-by: Antonio Fischetti <antonio.fische...@intel.com> >> Signed-off-by: Antonio Fischetti <antonio.fische...@intel.com> >> Acked-by: Daniele Di Proietto <diproiet...@vmware.com> > > It looks like the Windows build was broken after this change: > https://ci.appveyor.com/project/blp/ovs/build/1.0.2391 > > Will one of you take a look?
The example in include/openvswitch/compiler.c has the OVS_ALIGNED_VAR() before the declaration, not after, so changing the modified line accordingly might help. I’d not want to propose a patch before testing that this fixes the Windows build, though, and I do not have access to a Windows build system… Jarno _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
