>
> 'dev->requested_{rxq,txq}_size' and 'dev->{rxq,txq}_size' are
> relevant only for DPDK_DEV_ETH devices and should be skipped
> in 'netdev_dpdk_get_config()' for other ports.
>
> CC: Ciara Loftus <[email protected]>
> Fixes: b685696b8c81 ("netdev-dpdk: Allow configurable queue sizes for
> 'dpdk' ports")
Consider this Acked. I implemented the fix already in the vHost PMD RFC:
http://openvswitch.org/pipermail/dev/2016-October/080652.html
Better I guess to get it in earlier.
Thanks,
Ciara
>
> Signed-off-by: Ilya Maximets <[email protected]>
> ---
> lib/netdev-dpdk.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> index 7c1523e..b0beb37 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -1054,13 +1054,18 @@ netdev_dpdk_get_config(const struct netdev
> *netdev, struct smap *args)
> smap_add_format(args, "configured_rx_queues", "%d", netdev->n_rxq);
> smap_add_format(args, "requested_tx_queues", "%d", dev-
> >requested_n_txq);
> smap_add_format(args, "configured_tx_queues", "%d", netdev->n_txq);
> - smap_add_format(args, "requested_rxq_descriptors", "%d",
> - dev->requested_rxq_size);
> - smap_add_format(args, "configured_rxq_descriptors", "%d", dev-
> >rxq_size);
> - smap_add_format(args, "requested_txq_descriptors", "%d",
> - dev->requested_txq_size);
> - smap_add_format(args, "configured_txq_descriptors", "%d", dev-
> >txq_size);
> smap_add_format(args, "mtu", "%d", dev->mtu);
> +
> + if (dev->type == DPDK_DEV_ETH) {
> + smap_add_format(args, "requested_rxq_descriptors", "%d",
> + dev->requested_rxq_size);
> + smap_add_format(args, "configured_rxq_descriptors", "%d",
> + dev->rxq_size);
> + smap_add_format(args, "requested_txq_descriptors", "%d",
> + dev->requested_txq_size);
> + smap_add_format(args, "configured_txq_descriptors", "%d",
> + dev->txq_size);
> + }
> ovs_mutex_unlock(&dev->mutex);
>
> return 0;
> --
> 2.7.4
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
