Making both, javassist and cglib, an optional dependency gives the user the choice which one he would like to use. If another library already depends on e.g. cglib (like hibernate), it would make sense not to force the user to additionally have javassist in classpath, especially if we have an abstraction layer from proxy factory usage with commons-proxy.
br, Sven 2010/2/26 Mark Struberg <[email protected]> > Think that's not really possible Gurkan, because java.lang.reflect.proxy is > a pure interface proxy. So all methods which are provided by a normal class > and don't implement an interface wont work any longer. > > I fear there is actually only javassist, cglib, asm and AspectJ which does > what we need. > > I mean it would be possible, but only by ourself writing bytecode > enhancement stuff. I fixed javassist in that respect, so it's not undoable, > but still a lot of work. > > I will try to sit together with davidrallen this weekend and fix javassist > and first of all write proper junit tests for it - currently there are only > 4 of them, which is not much for such an important piece of code ;) > > LieGrue, > strub > > > --- Gurkan Erdogdu <[email protected]> schrieb am Fr, 26.2.2010: > > > Von: Gurkan Erdogdu <[email protected]> > > Betreff: Re: Java EE Independent Core > > An: [email protected] > > Datum: Freitag, 26. Februar, 2010 13:11 Uhr > > I am also thinking to remove > > javassist and use standard Java Proxy. Also, > > removing scannotation from webbeans-impl because scanning > > process will be > > handled by SPI implementation. (Imlpementation of the > > ScannerService SPI). > > > > > > 2010/2/26 James Carman <[email protected]> > > > > > So, now we're only down to (theoretically in the near > > future): > > > > > > SLF4J (for logging) > > > commons-proxy (for proxy creation) > > > javassist/cglib (to be chosen by deployment > > environment, could be > > > optional if user is only proxying interfaces and not > > beans?) > > > scannotation (for scanning the classpath for annotated > > classes) > > > > > > geronimo-interceptor-spec (specification to be > > provided by "container" > > > hopefully) > > > jcdi-api (specification to be provided by "container" > > hopefully) > > > atinject-api (specification to be provided by > > "container" hopefully) > > > > > > So, we're really only looking at 4 dependencies > > besides the API that > > > we depend on? Not too shabby. Of course, > > there would need to be an > > > SLF4J "impl" jar in there somewhere. > > > > > > 2010/2/26 Sven Linstaedt <[email protected]>: > > > > I will create a issue for this task. > > > > > > > > br, Sven > > > > > > > > > > > > 2010/2/26 Gurkan Erdogdu <[email protected]> > > > > > > > >> Hi Sven; > > > >> > > > >> Actually I have used dom4j to parse more > > complex XML that was defined by > > > >> earlier versions of the specification. I > > think that we can remove XML > > > parts > > > >> of the code base and use Java Standard > > Parsers instead of Dom4j. > > > >> > > > >> This probably will be done after releasing > > M4. > > > >> > > > >> Thanks; > > > >> > > > >> --Gurkan > > > >> > > > >> 2010/2/26 Sven Linstaedt <[email protected]> > > > >> > > > >> > Call me ignorant, but what is dom4j good > > for? ;) Afaik beans.xml > > > schema > > > >> is > > > >> > not very complex. Is there other xml we > > need to parse, besides this > > > one? > > > >> > Otherwise I would like to suggest using > > jre built in dom or sax > > > parsers. > > > >> > wdyt? > > > >> > > > > >> > Besides this one: I appreciate your > > idea, so +1 > > > >> > > > > >> > br, Sven > > > >> > > > > >> > > > > >> > > > > >> > 2010/2/26 Mark Struberg <[email protected]> > > > >> > > > > >> > > big +1 :) > > > >> > > > > > >> > > LieGrue, > > > >> > > strub > > > >> > > > > > >> > > --- Gurkan Erdogdu <[email protected]> > > schrieb am Fr, > > > 26.2.2010: > > > >> > > > > > >> > > > Von: Gurkan Erdogdu <[email protected]> > > > >> > > > Betreff: Java EE Independent > > Core > > > >> > > > An: [email protected] > > > >> > > > Datum: Freitag, 26. Februar, > > 2010 01:03 Uhr > > > >> > > > Hi; > > > >> > > > > > > >> > > > As we have discussed some time > > ago, Mark and some other > > > >> > > > folks would like to use OWB > > without any dependency on Java > > > >> > > > EE. I did more than this, and > > remove all Java EE and Web > > > >> > > > dependency from webbeans-impl. > > It just depends on EL-API > > > >> > > > because of BeanManager API > > uses it. > > > >> > > > > > > >> > > > Now, it depends on following > > jars. I have also created some > > > >> > > > other projects related with > > full Java EE and Java Web > > > >> > > > technologies. > > > >> > > > > > > >> > > > Dependent Jars > > > >> > > > --------------------- > > > >> > > > log4j (think to drop it also) > > > >> > > > dom4j > > > >> > > > javassist > > > >> > > > scannotation > > > >> > > > geronimo-interceptor-spec > > > >> > > > jcdi-api > > > >> > > > atinject-api > > > >> > > > > > > >> > > > New Projects > > > >> > > > ----------------------- > > > >> > > > webbeans-web --> Supports > > web > > > >> > > > webbeans-ee --> Fully > > EE Environment > > > >> > > > webbeans-ee-common --> Some > > commons > > > >> > > > > > > >> > > > I will hold it until releasing > > M4. In the mean time please > > > >> > > > do not commit big changes to > > trunk. > > > >> > > > > > > >> > > > Thanks; > > > >> > > > > > > >> > > > --Gurkan > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > > > ___________________________________________________________________ > > > >> > > > Yahoo! Türkiye > > açıldı! http://yahoo.com.tr > > > >> > > > İnternet üzerindeki en iyi > > içeriği Yahoo! Türkiye > > > >> > > > sizlere sunuyor! > > > >> > > > > > >> > > > > __________________________________________________ > > > >> > > Do You Yahoo!? > > > >> > > Sie sind Spam leid? Yahoo! Mail > > verfügt über einen herausragenden > > > >> Schutz > > > >> > > gegen Massenmails. > > > >> > > http://mail.yahoo.com > > > >> > > > > > >> > > > > >> > > > >> > > > >> > > > >> -- > > > >> Gurkan Erdogdu > > > >> http://gurkanerdogdu.blogspot.com > > > >> > > > > > > > > > > > > > > > -- > > Gurkan Erdogdu > > http://gurkanerdogdu.blogspot.com > > > > __________________________________________________ > Do You Yahoo!? > Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz > gegen Massenmails. > http://mail.yahoo.com >
