[
https://issues.apache.org/jira/browse/OWB-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869609#action_12869609
]
Paul J. Reder commented on OWB-375:
-----------------------------------
I'm submitting a patch that cleans up log messages again, and addresses this
performance issue by using formatted strings and variable arg lists for these
logs instead of "+" concatenation. That way the existing checks for log level
will prevent processing from happening.
In the future, no log messages should be constructed as concats in the parms to
the log calls. Variable arg lists and format strings should be used to avoid
the performance concerns.
> Performance: OWB logging performs operations when logging disabled.
> --------------------------------------------------------------------
>
> Key: OWB-375
> URL: https://issues.apache.org/jira/browse/OWB-375
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Jacquelle Leggett
> Assignee: Gurkan Erdogdu
> Priority: Minor
> Fix For: 1.1.0
>
>
> Logging operations in OWB code are not guarded by Logger.isLoggable(..) or
> something similar and results in Strings being processed when logging is
> disabled.
> Here's an example from AbstractInjectable:
> logger.debug("Injected into bean : " +
> this.injectionOwnerBean.toString() + " with injection point : " +
> injectionPoint);
> The String concatenation above will occur whether or not logging is enabled.
> WebBeansLogger should be modified so that the above can be changed to:
> if(logger.isDebugEnabed())
> logger.debug("Injected into bean : " +
> this.injectionOwnerBean.toString() + " with injection point : " +
> injectionPoint);
>
> Generally speaking, it's best for logging statements to be guarded by an
> isEnabled() flag to prevent performance impacts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
