[
https://issues.apache.org/jira/browse/OWB-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895189#action_12895189
]
Mark Struberg commented on OWB-385:
-----------------------------------
please allow me a few questions:
1.) please use a simple svn diff on the commandline for creating patchfiles.
Eclipse generated patchfiles are most times horribly broken!
2.) why do we need to use Externalizable over Serializable? We do just
transport in java modus and not in our own format or XML and stuff.
3.) did it compile? I get [INFO] You have 43 Checkstyle violations.
> implement passivation of managed beans in ServletContextListener
> ----------------------------------------------------------------
>
> Key: OWB-385
> URL: https://issues.apache.org/jira/browse/OWB-385
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.0.0-alpha-1
> Reporter: Eric Covener
> Assignee: YING WANG
> Fix For: 1.0.0-alpha-2
>
> Attachments: owb-385-1.patch
>
> Original Estimate: 60h
> Remaining Estimate: 60h
>
> Message-ID: <[email protected]>
> Currently we have no support for those callbacks for managed beans. Also
> includes AroundTimeout method.
> Motivation
> ----------------------
> Actually we have 2 methods in WebBeansConfigurationListener. Currently our
> session and conversation context does not provided actiovation/passivation.
> What we have to do is that we update below lifecycle callbacks to put all
> session and conversation context instances into the session in the
> "sessionWillPassivate" and call passivate callback, and reverse it on
> "sessionDidActivate".
> Those areas needs some contributions :)
> /**
> * {...@inheritdoc}
> */
> @Override
> public void sessionDidActivate(HttpSessionEvent event)
> {
> //TODO activation
> //Gets all passivated instances from passivated session and restore our
> session and conversation context.
> }
> /**
> * {...@inheritdoc}
> */
> @Override
> public void sessionWillPassivate(HttpSessionEvent event)
> {
> //TODO Passivation
> //Gets all instances from the Session and ConversationContexts
> and add those into the session that is under passivation therefore our
> bean instances
> are correctly passivated
> }
> Thanks;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
