Gurkan, PLEEEASSE profile this checkin and then REVERT IT AGAIN! There is a reason why I commented it clearly! This is a passage which will get used MILLIONS of times in a second!
This will slow down OWB HEAVILY in all situations where we do not log to jul directly but have a logging bridge involved like with Geronimo which uses pax logging! ALSO: PLEASE ONLY CHECKIN WITH A JIRA! LieGrue, strub --- On Wed, 9/8/10, [email protected] <[email protected]> wrote: > From: [email protected] <[email protected]> > Subject: svn commit: r993621 - > /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java > To: [email protected] > Date: Wednesday, September 8, 2010, 6:10 AM > Author: gerdogdu > Date: Wed Sep 8 06:10:18 2010 > New Revision: 993621 > > URL: http://svn.apache.org/viewvc?rev=993621&view=rev > Log: > Check Log level before logging. > > Modified: > > openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java > > Modified: > openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java > URL: > http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java?rev=993621&r1=993620&r2=993621&view=diff > ============================================================================== > --- > openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java > (original) > +++ > openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/intercept/InterceptorHandler.java > Wed Sep 8 06:10:18 2010 > @@ -187,8 +187,12 @@ public abstract class > InterceptorHandler > > > if(ClassUtil.isObjectMethod(methodName) > && !methodName.equals("toString")) > { > - // > we must not log in this place because this almost takes away > half of the performance! > - // > logger.trace("Calling method on proxy is restricted except > Object.toString(), but current method is Object. [{0}]", > methodName); > + // > we must not log in this place because this almost takes away > half of the performance! > + > //GE : Log on TRACE Level > + > if(logger.wblWillLogTrace()) > + { > + > logger.trace("Calling method on proxy is > restricted except Object.toString(), but current method is > Object. [{0}]", methodName); > + } > } > > else > if (bean instanceof InjectionTargetBean<?>) > > >
