Yes, exactly! The isLogEnabled might also cause a slowdown if called millions of times. This effect gets worse if some logging-bridge is involved. In geronimo where pax-logging is used it degrades mentionable. And when used with a JavaUtilLoggingToCommonsLogging bridge, the effect is even worse.
I think before we log something, we should make sure that we all have the same understanding about _why_ the invoked call is problematic. LieGrue, strub --- On Thu, 9/23/10, Gurkan Erdogdu <[email protected]> wrote: > From: Gurkan Erdogdu <[email protected]> > Subject: Re: [DISCUSS] remove logging for "Calling method on proxy is > restricted except Object.toString()" > To: [email protected] > Date: Thursday, September 23, 2010, 3:08 PM > Hello Mark, > > Point is that if we do not log the call (as trace level), > if any problem occurs > how a developer could find an issue related with calling > hashCode or equals on > proxy! Log level is trace, therefore it will not log if the > level is not trace. > > > Do you think that just calling if(logger.wblWillLogTrace()) > will decrease > performance as visible ? Do you evaulate the performance > with/without this > statement? > > Situation is the same for all proxy based techonlogies. > Then, don't we use > loggers on proxy based frameworks? > > Thanks; > > > Gurkan > > > > ----- Original Message ---- > From: Mark Struberg <[email protected]> > To: [email protected] > Sent: Thu, September 23, 2010 5:14:44 PM > Subject: [DISCUSS] remove logging for "Calling method on > proxy is restricted > except Object.toString()" > > hoi! > > Just for cleaning this up finally. > > Our InterceptorHandler contains a log.trace with the > following wording: > > logger.trace("Calling method on proxy is restricted > except Object.toString(), > >but current method is Object. [{0}]", methodName); > > Is this really a problematic situation? > > I mean this ALWAYS happens if a bean gets stored in a Map > or any other situation > where equals() or hashCode() is being invoked. > > I'd strongly favour to remove this logging. > > LieGrue, > strub > > >
