[
https://issues.apache.org/jira/browse/OWB-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918004#action_12918004
]
Martin Kočí commented on OWB-467:
---------------------------------
> Therefore solution using filter is not a good idea.
Filter was only suggestion beacuse it was already there. Also Apache Orchestra
requires filter for non-faces requests:
http://myfaces.apache.org/orchestra/myfaces-orchestra-core/installation.html.
Is ServletRequestListener more suitable here?
> Move init/destroy of conversation from phase listener to servlet filter
> -----------------------------------------------------------------------
>
> Key: OWB-467
> URL: https://issues.apache.org/jira/browse/OWB-467
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.0.0-alpha-2
> Environment: OWB trunk
> Reporter: Martin Kočí
> Assignee: Gurkan Erdogdu
> Priority: Critical
>
> OWB code for init/destroy conversation is in a phase listener. It is not
> safe: see http://markmail.org/message/oz7f7jnchwvrcw65. This phase listener
> approach also does not allow conversation for non faces request, but CDI spec
> says: "The conversation scope is active: during all standard lifecycle phases
> of any JSF faces or non-faces request". So this issue is critical for two
> reasons:
> 1) it does not allow conversation for non-faces request (specification says
> it must)
> 2) it can lock conversation forever (or only for timeout period?) and exhaust
> memory with locked conversations
> Proposed solution: move code to servlet filter as discussed at
> http://markmail.org/message/oz7f7jnchwvrcw65
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
