I think that this has to be rolled back according to the http://markmail.org/message/g6c4zsuuzckeai26
Becuase spec is wrong! Thanks; --Gurkan ----- Original Message ---- From: "[email protected]" <[email protected]> To: [email protected] Sent: Sun, November 14, 2010 10:45:17 AM Subject: svn commit: r1034955 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/event/NotificationManager.java test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java Author: djencks Date: Sun Nov 14 08:45:17 2010 New Revision: 1034955 URL: http://svn.apache.org/viewvc?rev=1034955&view=rev Log: OWB-490 CDITCK-174 correct order of generic parameters Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java?rev=1034955&r1=1034954&r2=1034955&view=diff ============================================================================== --- openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java (original) +++ openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java Sun Nov 14 08:45:17 2010 @@ -353,13 +353,7 @@ public final class NotificationManager { Type beanClassArg = actualArgs[0]; Type returnClassArg = actualArgs[1]; - - if(isObserverMethod) - { - beanClassArg = actualArgs[1]; - returnClassArg = actualArgs[0]; - } - + if(checkEventTypeParameterForExtensions(beanClass, beanClassArg) && checkEventTypeParameterForExtensions(producerOrObserverReturnClass, returnClassArg)) { Modified: openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java?rev=1034955&r1=1034954&r2=1034955&view=diff ============================================================================== --- openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java (original) +++ openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java Sun Nov 14 08:45:17 2010 @@ -40,9 +40,9 @@ public class AddObserverMethodExtension public static class MyBeanExtension implements Extension { - public static ObserverMethod<MyEvent> observerMethod; + public static ObserverMethod<AddObserverMethodExtension> observerMethod; - public void observer(@Observes ProcessObserverMethod<MyEvent, AddObserverMethodExtension> event) + public void observer(@Observes ProcessObserverMethod<AddObserverMethodExtension, MyEvent> event) { observerMethod = event.getObserverMethod();
