On Aug 29, 2010, at 10:34 PM, David Blevins wrote: > > On Aug 29, 2010, at 9:45 PM, Mark Struberg wrote: > >> Yes David. As posted in some Jira issue I'd like to aim for moving all those >> little helper classes as members to BeanManager and giving them a back >> reference >> to 'their' BeanManager. So all the 'helpers' can accessed via e.g. >> bm.getDefinitionUtil(); and definitionUtil can easily access the BeanManager >> via >> the back reference it got with the constructer as bm. >> >> This way we would be able to keep utils which are perfectly pre-configured >> for >> each webapp and additionally eliminate most of the unnecessary calls. >> >> wdyt? > > Count me in for helping with that :) Would be a fantastic change. > >> Oh yea, all work on this will be done after -alpha-2 of course ;) > > Anxiously waiting :)
Picking this thread up again as I see there's renewed interest in taking this on (i.e. Mark's weekend task :) Created a JIRA for us: https://issues.apache.org/jira/browse/OWB-503. Didn't bother assigning it to myself as it's not really a one person task -- we could all hammer on it. Checked in a little something to get us going. Basically just attempting to strongly type that second hashmap. I'm a big fan of incremental refactoring and this seemed like a nice baby-step that didn't require us to break the existing WebBeansFinder API, yet still get moving on going where we want to go. It may turn out we want to keep some API like the finder. We have a few statics in OpenEJB. Sometimes that's the more pragmatic design choice. Anyway, as usual, changing anything you like. Will continue hacking on it for the remainder of the week. Won't be hacking on it in the weekend (wedding anniversary this saturday), so Mark can hack all he wants without fear of bumping into me :) -David
