Irrespective of what happens to this commit, do you see any spec support for installing OwbApplicationFactory for every jsf-aware web beans app? AFAICT there is none and installing it is a convenience for users that they may or may not want. If you see something in the spec contrary to this I would like to know about it. Since I don't see any spec support for this I wonder if installing it automatically results in portable apps.
thanks david jencks On Dec 6, 2010, at 12:24 PM, Gurkan Erdogdu wrote: > Hi David > we designed owb as a plugin way. When he wants to add jsf support, he simply > drops webeansjsf.jar into classpath. Removing factory from faces config > prohibits it. Therefore this issue must be resolved on geronimo side instead > of owb site. moreover, not every jsf application must be assumed as cdi > application. for being cdi, there exist beans.xml under web-inf.therefore i > will revert this change. > > Pzt, 06 Ara 2010 20:19 EET tarihinde djen...@apache.org şöyle yazdı: > >> Author: djencks >> Date: Mon Dec 6 18:19:24 2010 >> New Revision: 1042754 >> >> URL: http://svn.apache.org/viewvc?rev=1042754&view=rev >> Log: >> OWB-505 don't install OwbApplicationFactory by default >> >> Modified: >> >> openwebbeans/trunk/webbeans-jsf/src/main/resources/META-INF/faces-config.xml >> >> Modified: >> openwebbeans/trunk/webbeans-jsf/src/main/resources/META-INF/faces-config.xml >> URL: >> http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-jsf/src/main/resources/META-INF/faces-config.xml?rev=1042754&r1=1042753&r2=1042754&view=diff >> ============================================================================== >> --- >> openwebbeans/trunk/webbeans-jsf/src/main/resources/META-INF/faces-config.xml >> (original) >> +++ >> openwebbeans/trunk/webbeans-jsf/src/main/resources/META-INF/faces-config.xml >> Mon Dec 6 18:19:24 2010 >> @@ -24,10 +24,6 @@ under the License. >> >> <name>org_apache_openwebbeans</name> >> >> - <factory> >> - >> <application-factory>org.apache.webbeans.jsf.OwbApplicationFactory</application-factory> >> - </factory> >> - >> <application> >> >> <view-handler>org.apache.webbeans.jsf.ConversationAwareViewHandler</view-handler> >> <el-resolver>org.apache.webbeans.el.WebBeansELResolver</el-resolver> >> >> > > >
