Yes remove all auto format stuff from your IDE please. And also all automated import ordering. That usually just messes up every commit and pollutes the commit history. Every IDE (sometimes even version) does this different thus we would just override changes from the previous committer.
And please also only use spaces. We shall not have a single tab in our sources :) I always suggest to enable whitespace viewing in your IDE. LieGrue, strub ----- Original Message ----- > From: Thomas Andraschko <zoi...@gmail.com> > To: dev@openwebbeans.apache.org > Cc: > Sent: Wednesday, September 12, 2012 8:38 PM > Subject: Re: Fw: [DISCUSS] release OWB-1.1.6 end of this week? > > i know, sorry. Should i deactivate "remove trailing spaces" in my IDE? > > 2012/9/12 Joseph Bergmark <bergm...@apache.org> > >> I started to review the patch, and the changes I saw looked good, but >> there is so much whitespace reformatting in that patch that its hard >> to focus on just the implementation changes. >> >> Sincerely, >> >> Joe >> >> On Wed, Sep 12, 2012 at 2:24 PM, Thomas Andraschko <zoi...@gmail.com> >> wrote: >> > Hi Mark, >> > >> > it's already fixed but i attached an patch with some refactoring + >> > unittests to #OWB-702. >> > I know that i could commit it but it would be great if anyone could >> review >> > it :) >> > >> > Regards, >> > Thomas >> > >> > 2012/9/12 Mark Struberg <strub...@yahoo.de> >> > >> >> 2nd try as my previous got eaten by the spam filter :/ >> >> >> >> >> >> >> >> >> >> >> >> ----- Forwarded Message ----- >> >> >From: Mark Struberg <strub...@yahoo.de> >> >> >To: openwebbeans-dev <dev@openwebbeans.apache.org> >> >> >Sent: Wednesday, September 12, 2012 7:49 PM >> >> >Subject: [DISCUSS] releaese OWB-1.1.6 end of this week? >> >> > >> >> > >> >> >Hi folks! >> >> > >> >> >I would like to start with a hot-fix release of OWB (version > 1.1.6) end >> >> of this week. >> >> >Thomas, is this an ok timeframe in which you can fix the > issues you >> >> needed for your production? >> >> > >> >> >LIeGrue, >> >> >strub >> >> > >> >> > >> >> > >> >> > >> >> > >> >> >> >
