Agree it is not covered but was weird to not inherit from "void notify(EventContext<T> eventContext)" if notifyWith was not already called. Maybe something to clarify - no strong opinions for one or the other while it is clear?
Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn 2017-12-06 9:13 GMT+01:00 Mark Struberg <[email protected]>: > No, read should just take over the meta-info from the other Observer. > Since the EventConsumer cannot be extracted from the ObserverMethod interface > (afair) we also cannot copy it. > > I guess this boils down to non-portable behaviour. At least there is no TCK > test which requires to copy it. > > LieGrue, > strub > >> Am 06.12.2017 um 06:58 schrieb Romain Manni-Bucau <[email protected]>: >> >> Hmm, looked matching but thought "read" as copy - including the observer. >> >> What i do is to observe all observers of a type, veto them all, then select >> the one i want and reinject it as an observer. Can be a bit limit as case, >> not sure. >> >> Le 5 déc. 2017 23:31, "Mark Struberg" <[email protected]> a écrit : >> >>> usually not, isn't? >>> >>> LieGrue, >>> strub >>> >>> >>>> Am 05.12.2017 um 22:26 schrieb Romain Manni-Bucau <[email protected] >>>> : >>>> >>>> Isnt notify adapted? >>>> >>>> Le 5 déc. 2017 21:23, "Mark Struberg" <[email protected]> a >>> écrit : >>>> >>>>> I think it's fine. >>>>> >>>>> With which callback would you fill it? >>>>> The Observer might not be a configured Observer. It is actually rather >>> an >>>>> exceptional case I'd say. >>>>> >>>>> LieGrue, >>>>> strub >>>>> >>>>>> Am 04.12.2017 um 17:08 schrieb Romain Manni-Bucau < >>> [email protected] >>>>>> : >>>>>> >>>>>> Hi guys, >>>>>> >>>>>> shouldnt org.apache.webbeans.configurator. >>> ObserverMethodConfiguratorImpl >>>>> #read(javax..enterprise.inject.spi.ObserverMethod) >>>>>> automatically fill notifyWith? ATM it is not self sufficient. >>>>>> >>>>>> Romain Manni-Bucau >>>>>> @rmannibucau | Blog | Old Blog | Github | LinkedIn >>>>> >>>>> >>> >>> >
