On Wed, Jun 19, 2019 at 11:37 AM Romain Manni-Bucau <rmannibu...@gmail.com> wrote:
> Le mer. 19 juin 2019 à 11:16, Rémy Maucherat <r...@apache.org> a écrit : > > > On Tue, Jun 18, 2019 at 10:26 PM Romain Manni-Bucau < > rmannibu...@gmail.com > > > > > wrote: > > > > > +1 to merge (replace) it in owb module since tomcat adherance is > reduced > > > thanks your refactos. > > > > > > The few weird things I saw - but guess it is inherited from our owb > > module > > > and cdi 1 times are: > > > > > > 1: dont start cdi if there is no beans.xml in webinf (in cdi 2 it > should > > be > > > anyway) > > > > > > > I don't see the bug there. The tomcat7 code seems to do that and it > appears > > to work for me (no CDI logging without a /WEB-INF/beans.xml): > > > > > https://github.com/apache/openwebbeans/blob/trunk/webbeans-tomcat7/src/main/java/org/apache/webbeans/web/tomcat7/ContextLifecycleListener.java#L63 > > > > > This is the bug, CDI must start without a beans.xml (annotated mode is > implicit) > Ok, no problem. This is a good justification to start adding some configuration options, so it starts there. I will create a jira with the patch for this tomcat9 integration code next. Rémy
