Yep but it is likely never used as such in normal apps (all but jsf) or it
is indirected by an appscoped bean injection so no real issue ;).

Real issue is that our configuration objext constructor has logic broken by
proxying so this was the least  breaking solution - ignoring ugly
try/catch(noop) - IMHO.

Happy to refine if it breaks users but i dont see an use case today.

Le mar. 27 oct. 2020 à 21:00, Mark Struberg <strub...@yahoo.de.invalid> a
écrit :

> Basically +1, but remember that one needs to deal with Serializable
> themselves when directly injecting beans. Plus our @ApplicationScoped
> normalscoping proxies are blazingly fast. There is simply no performance
> benefit at all. It's pure java native delegation which likely even gets
> erased in JIT.
>
> LieGrue,
> strub
>
>
> > Am 26.10.2020 um 21:02 schrieb Romain Manni-Bucau <rmannibu...@gmail.com
> >:
> >
> > Just to let you know, i did a few changes:
> >
> > 1. dropped some transitive but undesired dependencies of cxf (jboss rmi
> > spec jar for ex)
> > 2. make configuration and meecrowave beans (as cdi beans) @Dependent.
> > Functionally they are singleton but we likely want to avoid to reproxy
> them
> > since the producer is handling the singleton behavior. It also avoids
> > proxying issues in "without unsafe" mode.
> > 3. enabled to use jpa extension without using unsafe (just a scope fix)
> > 4. upgraded to owb snapshot to avoid breaking our logging configuration
> > (without owb snapshot OWB will always use JUL and never log4j2 until you
> > set it yourself on the JVM which is undesired and a regression).
> >
> > So long story short: think we are good to release as soon as cxf, openjpa
> > and owb are released so guess we will wait for the first one or "up" the
> > thread about it mainly?
> > wdyt?
> > I can handle owb/meecrowave ones if you want.
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
> >
> >
> > Le dim. 18 oct. 2020 à 11:40, Mark Struberg <strub...@yahoo.de.invalid>
> a
> > écrit :
> >
> >> hmm, jus figured that this also affects OWB. Will re-roll the OWB
> release.
> >>
> >> LieGrue,
> >> strub
> >>
> >>
> >>> Am 18.10.2020 um 11:13 schrieb Romain Manni-Bucau <
> rmannibu...@gmail.com
> >>> :
> >>>
> >>> Le dim. 18 oct. 2020 à 10:16, Mark Struberg <strub...@yahoo.de.invalid
> >
> >> a
> >>> écrit :
> >>>
> >>>> What do you mean with asm9 did leak?
> >>>>
> >>>
> >>> Xbean shade brings ow2 asm9 so we have undesired deps now. Must be
> >> exluded
> >>> from dep tree.
> >>>
> >>>
> >>>
> >>>> And will also roll an openjpa release.
> >>>> But that's an optional dependency, so doesn't matter that much.
> >>>>
> >>>
> >>> It does for our oauth2 module and fatjar and openjpa users which now
> >>> manages 2 xbean shades (which is undesired).
> >>> Guess we can wait 1 week for that and it is worth for consistency.
> >>>
> >>>
> >>>> LieGrue,
> >>>> strub
> >>>>
> >>>>> Am 18.10.2020 um 09:06 schrieb Romain Manni-Bucau <
> >> rmannibu...@gmail.com
> >>>>> :
> >>>>>
> >>>>> +1 once asm dependencies are aligned and fixed (asm9 leaked so must
> be
> >>>>> excluded and openjpa should be upgraded)
> >>>>>
> >>>>> Romain Manni-Bucau
> >>>>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> >>>>> <https://rmannibucau.metawerx.net/> | Old Blog
> >>>>> <http://rmannibucau.wordpress.com> | Github <
> >>>> https://github.com/rmannibucau> |
> >>>>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> >>>>> <
> >>>>
> >>
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >>>>>
> >>>>>
> >>>>>
> >>>>> Le dim. 18 oct. 2020 à 07:26, Jean-Baptiste Onofre <j...@nanthrax.net>
> a
> >>>>> écrit :
> >>>>>
> >>>>>> +1
> >>>>>>
> >>>>>> Go ahead ;)
> >>>>>>
> >>>>>> Thanks !
> >>>>>> Regards
> >>>>>> JB
> >>>>>>
> >>>>>>> Le 17 oct. 2020 à 23:36, Mark Struberg <strub...@yahoo.de.INVALID>
> a
> >>>>>> écrit :
> >>>>>>>
> >>>>>>> hi folks!
> >>>>>>>
> >>>>>>> I'd like to start OWB and Meecrowave Releases tomorrow morning.
> >>>>>>> Please shout if there is something to fix still.
> >>>>>>>
> >>>>>>> LieGrue,
> >>>>>>> strub
> >>>>>>>
> >>>>>>
> >>>>>>
> >>>>
> >>>>
> >>
> >>
>
>

Reply via email to