jgallimore commented on code in PR #126:
URL: https://github.com/apache/openwebbeans/pull/126#discussion_r1937556068
##########
webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java:
##########
@@ -1756,6 +1759,34 @@ protected void deployFromXML(ScannerService scanner)
}
logger.fine("Deploying configurations from XML has ended
successfully.");
+
+ try
Review Comment:
I think I understand :-).
Happy to debug around `addDeploymentUrl`, and see what I can find. What I
can tell you is that if you revert out the BeansDeployer change in this PR, the
tests in this PR will fail (or at least they do for me). I'm very happy to look
at a different fix (I might have questions.... :-) ), but I do think a fix is
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
