markusthoemmes commented on a change in pull request #2246: To resolve #2245 -
optimize container removal
URL:
https://github.com/apache/incubator-openwhisk/pull/2246#discussion_r116659469
##########
File path:
tests/src/test/scala/whisk/core/containerpool/test/ContainerPoolTests.scala
##########
@@ -381,6 +446,6 @@ class ContainerPoolObjectTests extends FlatSpec with
Matchers with MockFactory {
'largeYoung -> freeWorker(warmedData(namespace = largeNamespace,
lastUsed = Instant.ofEpochMilli(3))),
'largeOld -> freeWorker(warmedData(namespace = largeNamespace,
lastUsed = Instant.ofEpochMilli(2))))
- ContainerPool.remove(myData.invocationNamespace, pool) shouldBe
Some('largeOld)
+ ContainerPool.remove(myData.action, EntityName("anyNamespace"), pool)
shouldBe Some('largeOld)
Review comment:
Same comment as above. Could use `createAction()` as there is no direct
relationship to the data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
