Dear OpenWhiskers Want to first congratulate on Vincent on taking on the this major task on separating the CLI from the openwhisk core repo, which required many changes and a test framework based on REST API to replace the test cases that were using the CLI.
During the last 5 months Vincent have also being manually syncing the CLI code and related scala tests cases to the openwhiks-cli [1] and the openwhisk-client-go [2] repositories. Now what's left is to remove the CLI source code from the main repo, Vincent have open PR #29179 [3], and I will merge the PR by silent consensus if there are no objections in 72 hours, we'll merge the PR #2979. After the merge I will start moving the CLI open issues from the core repo to the openwhisk-cli repo [1]. We are also updating the runtimes and apigateway repos to adjust to the change. [1] https://github.com/apache/incubator-openwhisk-cli [2] https://github.com/apache/incubator-openwhisk-client-go [3] https://github.com/apache/incubator-openwhisk/pull/2979 On Fri, Jun 30, 2017 at 7:29 PM Carlos Santana <[email protected]> wrote: > This is great progress on CLI, Vincent > > It's very important to do it in this way to keep quality on both backend > API and CLI > > It's going be a bit annoying to keep duplicates code and tests between > repos > > But it's key to have tests on the REST API independent of the client side, > we have a few client side libraries for the API golang, JavaScript, python, > etc. > > We need the help from folks on best practices and implementation for the > two go packages base library and CLI/cobra > > -- Carlos > > On Wed, Jun 28, 2017 at 10:58 PM David ZL Liu <[email protected]> > wrote: > >> Hi Vincent, >> >> Very great job you have done, amazing! >> >> yes, please count me one and don't hesitate to assign me issues to >> investigate if you think I can help. It's my pleasure. >> >> >> Kind Regards, >> dliu >> >> >> >> >> From: "Vincent S Hou" <[email protected]> >> To: [email protected] >> Date: 2017-06-28 上午 02:20 >> Subject: OpenWhisk CLI separation from openwhisk repo: status and >> help >> >> >> >> >> Hi openwhiskers, >> >> OpenWhisk CLI is currently on the stage to separate from the main >> openwhisk >> repo for better modularity. We have already established two new >> repositories >> to respectively host the the Go client code and the Go CLI code: >> >> OpenWhisk Client Go: >> https://github.com/apache/incubator-openwhisk-client-go, originating >> from OpenWhisk Go Whisk( >> >> >> https://github.com/apache/incubator-openwhisk/tree/master/tools/cli/go-whisk >> >> ) >> OpenWhisk CLI: https://github.com/apache/incubator-openwhisk-cli, >> originating from OpenWhisk Go Whisk CLI( >> >> >> https://github.com/apache/incubator-openwhisk/tree/master/tools/cli/go-whisk-cli >> >> ) >> >> Current status: >> All the source code has been copied and adjusted in the new repos. Scala >> tests related to CLI have been moved into cli repo. Travis CIs for both >> repos are running >> the test cases in Scala to make sure the code works. The source code of >> each repo has already synchronized with openwhisk repo, and is able to do >> further sync-up. However, there is no integration test in openwhisk client >> go, and only a few integration tests implemented in Go for openwhisk cli. >> >> Most urgent work items to do next: >> >> OpenWhisk Client Go: Unit tests for all the Go files, and Integration >> tests against openwhisk service in Go. >> Issues opened: >> https://github.com/apache/incubator-openwhisk-client-go/issues/17, >> https://github.com/apache/incubator-openwhisk-client-go/issues/14 >> >> OpenWhisk Cli: Integration tests against openwhisk service in Go. (Unit >> tests remain to be discussed, since this repo is implemented in cobra >> package and calls openwhisk client go.) >> Issues opened: >> https://github.com/apache/incubator-openwhisk-cli/issues/17 >> >> OpenWhisk: We need to reimplement the Scala tests by calling the REST >> APIs instead of calling the binaries, which means the basic Wsk class >> needs to be rewritten: >> >> https://github.com/apache/incubator-openwhisk/blob/master/tests/src/test/scala/common/Wsk.scala >> >> , and invoked by all the other tests when accessing the openwhisk >> services. >> The current Wsk.scala is calling the CLI binary, and we need to call the >> rest api to order to departure the CLI. >> Issues opened: >> https://github.com/apache/incubator-openwhisk/issues/2430 >> >> We are moving forward in this direction now. Anyone interested in the >> contribution to this piece of work? Welcome to reach out to me. >> >> >> Best wishes. >> Vincent Hou >> >> >> >> >>
