csantanapr commented on a change in pull request #3: support large arguments
URL:
https://github.com/apache/incubator-openwhisk-runtime-docker/pull/3#discussion_r165844124
##########
File path: core/actionProxy/actionproxy.py
##########
@@ -127,18 +128,29 @@ def error(msg):
try:
input = json.dumps(args)
- p = subprocess.Popen(
- [self.binary, input],
- stdout=subprocess.PIPE,
- stderr=subprocess.PIPE,
- env=env)
+ if len(input) > 131071: # MAX_ARG_STRLEN (131071)
linux/binfmts.h
+ # pass argument via stdin
Review comment:
I agree and can also read your mind ?
Send the PR and I will merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
