Hi - 
We haven't heard any feedback on this, so will plan to merge this change today. 

Thanks
Tyson

On 11/14/18, 6:48 PM, "Andy Steed" <andst...@adobe.com.INVALID> wrote:

    Hello Whiskers!
    
    
    I wanted to bring up a potentially breaking change to existing 
functionality for the KindRestrictor. Given how recently this functionality was 
added, I do not expect this to affect others. However, I would like to have any 
concerns or objections raised with the group sooner than later.
    
    
    First, to give a little backstory. Previously, a feature was 
added<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-openwhisk%2Fpull%2F3661&amp;data=02%7C01%7Ctnorris%40adobe.com%7C473f794700ab4902fa9608d64aa4d117%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636778469082732045&amp;sdata=uMjM5Z4uDDI7w477svYWXo2ujqS%2F3spn8Gv7HokjmQ0%3D&amp;reserved=0>
 to support limiting the kinds that were allowed to be used when creating 
actions for a given namespace, as well as support for setting a default 
whitelist for the overall system. In the initial feature the whitelist set per 
namespace (if present) was used instead of the default whitelist.
    
    
    Now, I have opened a PR to adjust this 
logic<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-openwhisk%2Fpull%2F4114&amp;data=02%7C01%7Ctnorris%40adobe.com%7C473f794700ab4902fa9608d64aa4d117%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636778469082732045&amp;sdata=g8P9UDc%2B6DLVvu5OtkuNA4PbCRjR68maTJ%2FLd%2F2iqEE%3D&amp;reserved=0>,
 such that the explicit namespace limit for allowedKinds is viewed as a 
complement to the default system whitelist (if present). I have provided 
additional specifics in the PR description including reasoning behind the need 
for this change.
    
    
    Cheers,
    
    Andy
    
    
    

Reply via email to