I can give it a look this afternoon although Chetan's review looks thorough and the tests look good to me. I'll scrutinize them a bit more.
-r On Wed, Jan 30, 2019 at 10:18 AM Tyson Norris <[email protected]> wrote: > Hi – > I have a PR #4186 ready to merge that has some changes to critical areas > of ContainerPool for tracking concurrency; specifically so that initing > containers (not yet warm) can receive activation jobs, instead of current > behavior where additional containers will launch. While this only applies > to actions that support intra-container concurrency, the changes affect the > general ContainerProxy state management in ContainerPool. > Please review if you have concerns, or forever hold your peace (or until > the next PR 😊) > Chetan has already reviewed, but it would be great to have another pair of > eyes there. > https://github.com/apache/incubator-openwhisk/pull/4186 > > Thanks! > Tyson >
