Another minor point, the NOTICE refers to "Apache OpenWhisk" not the 'OpenWhisk JavaScript Client Library'.
-r On Tue, Mar 19, 2019 at 4:50 PM Rodric Rabbah <[email protected]> wrote: > +1 > > I wrote a script to verify this release. The gist is here > https://gist.github.com/rabbah/0f9e138c9088758c30fe31f05b893041 > You'll see sample output at the bottom. It detected the same issue raised > by Matt wrt the license, otherwise everything checked out. > > computing sha512 and validating... valid > verifying asc... valid > verifying disclaimer... valid > verifing notice... valid > verifying license... not valid (diff > '/var/folders/q9/s3th42s53d34ftd5wvcypybr0000gn/T/tmp.6t9xcMV8/incubator-openwhisk-client-js-3.19.0-incubating/LICENSE.txt' > '/var/folders/q9/s3th42s53d34ftd5wvcypybr0000gn/T/tmp.6t9xcMV8/LICENSE-2.0') > verifying sources have proper headers... valid > scanning for binaries... valid > > > -r > > > On Tue, Mar 19, 2019 at 2:49 PM Matt Sicker <[email protected]> wrote: > >> +1 >> >> Notes: >> >> * LICENSE has incorrect boilerplate example at bottom. It seems to >> have been replaced with a concrete example of IBM. This should >> probably be reverted to the original text of the ASLv2. >> * NPM says there are a few vulnerable dependencies. Neat feature, >> though unclear if they're real vulnerabilities (I'm not a JS expert >> like I am with Java). >> * Tests passing. >> * Standard checklist all passes. >> >> On Mon, 18 Mar 2019 at 22:29, Dominic Kim <[email protected]> wrote: >> > >> > +1 >> > >> > I could verify the artifacts with the key. >> > >> > [x] Download links are valid. >> > [x] Checksums and PGP signatures are valid. >> > [x] DISCLAIMER is included. >> > [x] Source code artifacts have correct names matching the current >> release. >> > [x] LICENSE and NOTICE files are correct for each OpenWhisk repository. >> > [x] All files have license headers if necessary. >> > [x] No compiled archives bundled in source archive. >> > >> > 2019년 3월 19일 (화) 오전 11:36, 甯尤刚 <[email protected]>님이 작성: >> > >> > > +1 >> > > >> > > I was able to verify the release artifacts for client-js 3.19 rc1 >> > > >> > > [x] Download links are valid. >> > > [x] Checksums and PGP signatures are valid. >> > > [x] DISCLAIMER is included. >> > > [x] Source code artifacts have correct names matching the current >> release. >> > > [x] LICENSE and NOTICE files are correct for each OpenWhisk >> repository. >> > > [x] All files have license headers if necessary. >> > > [x] No compiled archives bundled in source archive. >> > > >> > > -----Original Message----- >> > > From: "Carlos Santana"<[email protected]> >> > > To: <[email protected]>; >> > > Cc: >> > > Sent: 2019-03-19 (星期二) 10:18:28 (GMT+08:00) >> > > Subject: Re: [VOTE] Release Apache OpenWhisk Client JS (incubating) >> 3.19.0 >> > > >> > > +1 >> > > >> > > I was able to verify the release artifacts for client-js 3.19 rc1 >> > > >> > > [x] Download links are valid. >> > > [x] Checksums and PGP signatures are valid. >> > > [x] DISCLAIMER is included. >> > > [x] Source code artifacts have correct names matching the current >> release. >> > > [x] LICENSE and NOTICE files are correct for each OpenWhisk >> repository. >> > > [x] All files have license headers if necessary. >> > > [x] No compiled archives bundled in source archive. >> > > >> > > >> > > On Mon, Mar 18, 2019 at 5:50 PM Dave Grove <[email protected]> wrote: >> > > >> > > > I vote +1 Release as Apache OpenWhisk 3.19.0-incubating: OpenWhisk >> Client >> > > > JS >> > > > >> > > > I verified: >> > > > [ X ] Download links are valid. >> > > > [ X ] Checksums and PGP signatures are valid. >> > > > [ X ] DISCLAIMER is included. >> > > > [ X ] Source code artifacts have correct names matching the current >> > > > release. >> > > > [ X ] LICENSE and NOTICE files are correct for each OpenWhisk repo. >> > > > [ X ] All files have license headers if necessary. >> > > > [ X ] No compiled archives bundled in source archive. >> > > > >> > > > --dave >> > > > >> > > > On 2019/03/18 18:14:39, James Thomas <[email protected]> wrote: >> > > > > This is to call for a vote for the release of Apache OpenWhisk >> Client >> > > JS >> > > > > (incubating) 3.19.0 >> > > > > >> > > > > List of JIRA ticket(s) resolved for this release can be found at >> > > > > >> > > > > https://issues.apache.org/jira/browse/INCUBATOR-232. >> > > > > >> > > > > This release comprises of source code distribution only. There is >> only >> > > > one >> > > > > module within this release number 3.19.0. The artifact were built >> from >> > > > the >> > > > > following Git commit IDs: >> > > > > >> > > > > - >> > > > > >> > > > > openwhisk-client-js: 726b982, >> > > > > >> > > > > The source code artifact of openwhisk client js can be found at: >> > > > > >> > > > >> > > >> https://dist.apache.org/repos/dist/dev/incubator/openwhisk/apache-openwhisk-3.19.0-incubating-rc1/openwhisk-client-js-3.19.0-incubating-sources.tar.gz >> > > > > >> > > > > The SHA-512 checksum for the artifact of openwhisk client js is >> > > > > openwhisk-client-js-3.19.0-incubating-sources.tar.gz: 8D8FE6C5 >> 48F5FE72 >> > > > > F5C5CC2E 1539416F 84B18BB7 D6A0075B 50CAFC22 55BFA27E C8E60B9D >> 6660E203 >> > > > > 72CEB667 EAE91474 DAB16D8B 764B5141 8B7595DE 78CBA217 >> > > > > >> > > > > which can can be found via: >> > > > > >> > > > >> > > >> https://dist.apache.org/repos/dist/dev/incubator/openwhisk/apache-openwhisk-3.19.0-incubating-rc1/openwhisk-client-js-3.19.0-incubating-sources.tar.gz.sha512 >> > > > > >> > > > > The signature of the artifact of openwhisk client js can be found >> via: >> > > > > >> > > > >> > > >> https://dist.apache.org/repos/dist/dev/incubator/openwhisk/apache-openwhisk-3.19.0-incubating-rc1/openwhisk-client-js-3.19.0-incubating-sources.tar.gz.asc >> > > > > >> > > > > KEYS file is available here: >> > > > > https://dist.apache.org/repos/dist/dev/incubator/openwhisk/KEYS >> > > > > >> > > > > Please vote on releasing this package as Apache OpenWhisk >> > > > > 3.19.0-incubating: OpenWhisk Client JS >> > > > > >> > > > > The vote will be open for at least 72 hours. >> > > > > >> > > > > [ ] +1 Release as Apache OpenWhisk 3.19.0-incubating: OpenWhisk >> Client >> > > JS >> > > > > >> > > > > [ ] +0 no opinion >> > > > > >> > > > > [ ] -1 Do not release and the reason >> > > > > >> > > > > Checklist for reference: >> > > > > >> > > > > [ ] Download links are valid. >> > > > > >> > > > > [ ] Checksums and PGP signatures are valid. >> > > > > >> > > > > [ ] DISCLAIMER is included. >> > > > > >> > > > > [ ] Source code artifacts have correct names matching the current >> > > > release. >> > > > > >> > > > > [ ] LICENSE and NOTICE files are correct for each OpenWhisk repo. >> > > > > >> > > > > [ ] All files have license headers if necessary. >> > > > > >> > > > > [ ] No compiled archives bundled in source archive. >> > > > > >> > > > > Thank you very much. >> > > > > >> > > > > -- >> > > > > Regards, >> > > > > James Thomas >> > > > > >> > > > >> > > >> > > >> > > -- >> > > Carlos Santana >> > > <[email protected]> >> > > >> > > >> >> >> >> -- >> Matt Sicker <[email protected]> >> >
