markusthoemmes commented on a change in pull request #3: Fixing numerous issues
discovered whilst developing new event source
URL:
https://github.com/apache/incubator-openwhisk-pluggable-provider/pull/3#discussion_r290293704
##########
File path: actions/event-actions/changesWebAction.js
##########
@@ -36,7 +36,7 @@ function main(params) {
common.verifyTriggerAuth(triggerData, false)
.then(() => EventProvider.validate(params))
.catch(err => {
- return reject(common.sendError(400, `Feed parameter validation
failed`, err.message));
+ throw common.sendError(400, `Feed parameter validation failed`,
err.message);
Review comment:
If you return `Promise.reject` that should not happen. Javascript doesn't
care (or even know) what error values are, as long as the promise is rejected
underneath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
