This is a sensible change and I agree with what Rodric has suggested: can we make this a per-action annotation?
On Tue, 3 Sep 2019 at 13:28, Rodric Rabbah <rod...@gmail.com> wrote: > > > Action results may contain sensible data that should not be logged. > > I interpret this to mean: not stored in the activation record. > > If this is what you mean, why not make this a feature controlled per action > using an annotation and let the user decide: ok to save the result, not ok > to save the result, only save the result on error. > > -r > > On Tue, Sep 3, 2019 at 8:17 AM Ruediger Maass <ruediger.ma...@de.ibm.com> > wrote: > > > Action results may contain sensible data that should not be logged. There > > is a system configuration flag (writeResultToFile) that can be used to > > switch on or off the result inclusion in logs. But this is a global switch > > that holds for all activations. In our case we want to able to decide per > > activation whether or not the result should be included in the log or not. > > In our special case we want results to be included in case of errors (in > > other words, our predicate function for the decision is: 'Does the result > > contain an error field?'). But also other decision logic may be > > applicable. > > > > This PR https://github.com/apache/openwhisk/pull/4604 is a small change > > that extends ActivationFileStorage. > > > > Please help and comment on the PR. > > > > Thank you, Ruediger > > > > -- Regards, James Thomas
