2021-01-05 16:19:49 UTC - Shubham Gupta: Hi @Rodric Rabbah, I'm setting up openwhisk-client-go. once done with setup then i will try to change activation.go to fix status code wave : Rodric Rabbah +1 : Rodric Rabbah tada : Rodric Rabbah https://openwhisk-team.slack.com/archives/C3UDXSFA6/p1609863589019100?thread_ts=1609863589.019100&cid=C3UDXSFA6 ---- 2021-01-05 16:21:02 UTC - Rodric Rabbah: that’s great - thanks Shubham +1 : Shubham Gupta https://openwhisk-team.slack.com/archives/C3UDXSFA6/p1609863662019800?thread_ts=1609863589.019100&cid=C3UDXSFA6 ---- 2021-01-05 20:02:15 UTC - Shubham Gupta: @Rodric Rabbah I have changed the code in activation.go inside openwhisk-client-go repo. Could you please tell me how can i test this code to see whether status code issue has been fixed or not ? https://openwhisk-team.slack.com/archives/C3UDXSFA6/p1609876935020100?thread_ts=1609863589.019100&cid=C3UDXSFA6 ---- 2021-01-05 20:22:17 UTC - Rodric Rabbah: there aren’t many unit tests in the openwhisk-client-go repo, depending on how you implemented the fix, you can add a unit tests, or extend one of the cli tests but they are in another repo :confused: https://openwhisk-team.slack.com/archives/C3UDXSFA6/p1609878137020300?thread_ts=1609863589.019100&cid=C3UDXSFA6 ---- 2021-01-05 20:22:30 UTC - Rodric Rabbah: can you open a draft pr? https://openwhisk-team.slack.com/archives/C3UDXSFA6/p1609878150020500?thread_ts=1609863589.019100&cid=C3UDXSFA6 ---- 2021-01-05 20:26:37 UTC - Shubham Gupta: is it ok if i create my development branch from master branch ? https://openwhisk-team.slack.com/archives/C3UDXSFA6/p1609878397020700?thread_ts=1609863589.019100&cid=C3UDXSFA6 ---- 2021-01-05 20:27:04 UTC - Rodric Rabbah: on your fork? sure https://openwhisk-team.slack.com/archives/C3UDXSFA6/p1609878424020900?thread_ts=1609863589.019100&cid=C3UDXSFA6 ---- 2021-01-05 20:29:16 UTC - Shubham Gupta: yes i have forked openwhisk-clinet-go and creating my new branch from master https://openwhisk-team.slack.com/archives/C3UDXSFA6/p1609878556021100?thread_ts=1609863589.019100&cid=C3UDXSFA6 ---- 2021-01-05 20:37:13 UTC - Shubham Gupta: <https://github.com/apache/openwhisk-client-go/pull/142> https://openwhisk-team.slack.com/archives/C3UDXSFA6/p1609879033021300?thread_ts=1609863589.019100&cid=C3UDXSFA6 ---- 2021-01-05 20:38:31 UTC - Shubham Gupta: PR raised. please review This is my first code in go lang. So please suggest if you found anything wrong. https://openwhisk-team.slack.com/archives/C3UDXSFA6/p1609879111021500?thread_ts=1609863589.019100&cid=C3UDXSFA6 ---- 2021-01-05 20:38:54 UTC - Rodric Rabbah: great and congrats! +1 : Shubham Gupta https://openwhisk-team.slack.com/archives/C3UDXSFA6/p1609879134021700?thread_ts=1609863589.019100&cid=C3UDXSFA6 ---- 2021-01-05 21:09:15 UTC - Shubham Gupta: can i sign Apache CLA (Contributor License Agreement) now ? https://openwhisk-team.slack.com/archives/C3UDXSFA6/p1609880955022000?thread_ts=1609863589.019100&cid=C3UDXSFA6 ---- 2021-01-05 21:15:55 UTC - Rodric Rabbah: you should submit one - helpful if you might do more contributions https://openwhisk-team.slack.com/archives/C3UDXSFA6/p1609881355022300?thread_ts=1609863589.019100&cid=C3UDXSFA6 ---- 2021-01-05 21:18:25 UTC - Shubham Gupta: okk, i will do https://openwhisk-team.slack.com/archives/C3UDXSFA6/p1609881505022500?thread_ts=1609863589.019100&cid=C3UDXSFA6 ---- 2021-01-05 21:18:39 UTC - Shubham Gupta: i think it's mandatory for all contributors right ? https://openwhisk-team.slack.com/archives/C3UDXSFA6/p1609881519022700?thread_ts=1609863589.019100&cid=C3UDXSFA6 ----
