+1 to release openwhisk-runtime-nodejs 1.19.0

I have no issue with the updated rcverify.sh.

Thanks, David for handling this.

----------------------------------------------

$ ./rcverify.sh openwhisk-runtime-nodejs 1.19.0 rc1
rcverify.sh (script SHA1: 7FC5 5DBE 1809 6D92 DEFF  0E31 D138 059B 8F27
20F7)
working in the following directory:
/var/folders/jc/wfhtkrln4q7cz9pxz24rbkdm0000gp/T/tmp.nLqC6aVj
fetching tarball and signatures from
https://dist.apache.org/repos/dist/dev/openwhisk/rc1
fetching openwhisk-runtime-nodejs-1.19.0-sources.tar.gz... ok
fetching openwhisk-runtime-nodejs-1.19.0-sources.tar.gz.asc... ok
fetching openwhisk-runtime-nodejs-1.19.0-sources.tar.gz.sha512... ok
fetching apache license... ok
fetching release keys... ok
importing keys... ok (keys already imported (processed 11 unchanged 11))
unpacking tar ball... ok
cloning scancode... ok
computing sha512 for openwhisk-runtime-nodejs-1.19.0-sources.tar.gz... ok
openwhisk-runtime-nodejs-1.19.0-sources.tar.gz:
74F54D38 777815AD 531C11BD 67423E73 75B2057A 41D9B9A7 2A1E0AE2 F933E5B6
6831E929
 4EDE1BA8 5DF14270 FD370778 D9BE3EC6 AEE86F21 C018174F 10DF26D7
validating sha512... passed
verifying asc... passed (signed-by: Dave Grove <gro...@acm.org>)
verifying notice... passed
verifying absence of DISCLAIMER.txt passed
verifying license... passed
verifying sources have proper headers... passed
scanning for executable files... passed
scanning for unexpected file types...

 passed
scanning for archives... passed
scanning for packages... passed
scanning package.json for version match... passed (none detected)
scanning package-lock.json for version match... passed (none detected)
removing the scratch space
(/var/folders/jc/wfhtkrln4q7cz9pxz24rbkdm0000gp/T/tmp.nLqC6aVj)... ok

2021년 8월 12일 (목) 오전 12:10, David P Grove <gro...@us.ibm.com>님이 작성:

> Hi Dom,
>
> I was able to reproduce this locally.  It is an issue with rcverify, not
> with actual runtime-nodejs release.
>
>  I submitted a PR [1] to rcverify to add application/javascript as an
> acceptable mime type for files.    I'm not sure what has changed recently
> on my computer (tar? git? file? some lower level library?) but `file -mime`
> on the compile script is now returning application/javascript for me.  It
> used to return text.
>
> --dave
>
> [1] https://github.com/apache/openwhisk-release/pull/397
>
>
> [image: Inactive hide details for "Dominic Kim" ---08/10/2021 09:27:26
> PM---I am facing a failure while scanning unexpected file types.]"Dominic
> Kim" ---08/10/2021 09:27:26 PM---I am facing a failure while scanning
> unexpected file types. --dom
>
> From: "Dominic Kim" <style9...@gmail.com>
> To: dev@openwhisk.apache.org
> Date: 08/10/2021 09:27 PM
> Subject: [EXTERNAL] Re: [VOTE] Release Apache OpenWhisk Runtime Node.js
> (v1.19.0, rc1)
> ------------------------------
>
>
>
> I am facing a failure while scanning unexpected file types.
>
> --dom
>
> ---------------------------------
>
> $ ./rcverify.sh openwhisk-runtime-nodejs 1.19.0 rc1
> rcverify.sh (script SHA1: A042 C31A 38AF 8EBB F150  0819 A448 DE52 BFE1
> 258F)
> working in the following directory:
> /var/folders/jc/wfhtkrln4q7cz9pxz24rbkdm0000gp/T/tmp.lL1N5KUx
> fetching tarball and signatures from
> https://dist.apache.org/repos/dist/dev/openwhisk/rc1
> fetching openwhisk-runtime-nodejs-1.19.0-sources.tar.gz... ok
> fetching openwhisk-runtime-nodejs-1.19.0-sources.tar.gz.asc... ok
> fetching openwhisk-runtime-nodejs-1.19.0-sources.tar.gz.sha512... ok
> fetching apache license... ok
> fetching release keys... ok
> importing keys... ok (keys already imported (processed 11 unchanged 11))
> unpacking tar ball... ok
> cloning scancode... ok
> computing sha512 for openwhisk-runtime-nodejs-1.19.0-sources.tar.gz... ok
> openwhisk-runtime-nodejs-1.19.0-sources.tar.gz:
> 74F54D38 777815AD 531C11BD 67423E73 75B2057A 41D9B9A7 2A1E0AE2 F933E5B6
> 6831E929
> 4EDE1BA8 5DF14270 FD370778 D9BE3EC6 AEE86F21 C018174F 10DF26D7
> validating sha512... passed
> verifying asc... passed (signed-by: Dave Grove <gro...@acm.org>)
> verifying notice... passed
> verifying absence of DISCLAIMER.txt passed
> verifying license... passed
> verifying sources have proper headers... passed
> scanning for executable files... passed
> scanning for unexpected file types... failed
>
> (/var/folders/jc/wfhtkrln4q7cz9pxz24rbkdm0000gp/T/tmp.lL1N5KUx/openwhisk-runtime-nodejs-1.19.0/core/typescript37Action/bin/compile:
> application/javascript; charset=us-ascii)
> scanning for archives... passed
> scanning for packages... passed
> scanning package.json for version match... passed (none detected)
> scanning package-lock.json for version match... passed (none detected)
>
> run the following command to remove the scratch space:
>  rm -rf '/var/folders/jc/wfhtkrln4q7cz9pxz24rbkdm0000gp/T/tmp.lL1N5KUx'
>
>
>
>
> 2021년 8월 11일 (수) 오전 4:11, Rodric Rabbah <rod...@gmail.com>님이 작성:
>
> > +1 to release openwhisk-runtime-nodejs 1.19.0.  Release checked with
> > rcverify.
> >
> > >  ./rcverify.sh openwhisk-runtime-nodejs 1.19.0 rc1
> > rcverify.sh (script SHA1: A042 C31A 38AF 8EBB F150  0819 A448 DE52 BFE1
> > 258F)
> > working in the following directory:
> > /var/folders/q9/s3th42s53d34ftd5wvcypybr0000gn/T/tmp.vdNrvpLr
> > fetching tarball and signatures from
> > https://dist.apache.org/repos/dist/dev/openwhisk/rc1
> > fetching openwhisk-runtime-nodejs-1.19.0-sources.tar.gz... ok
> > fetching openwhisk-runtime-nodejs-1.19.0-sources.tar.gz.asc... ok
> > fetching openwhisk-runtime-nodejs-1.19.0-sources.tar.gz.sha512... ok
> > fetching apache license... ok
> > fetching release keys... ok
> > importing keys... ok (keys already imported (processed 11 unchanged 11))
> > unpacking tar ball... ok
> > cloning scancode... ok
> > computing sha512 for openwhisk-runtime-nodejs-1.19.0-sources.tar.gz... ok
> > openwhisk-runtime-nodejs-1.19.0-sources.tar.gz:
> > 74F54D38 777815AD 531C11BD 67423E73 75B2057A 41D9B9A7 2A1E0AE2 F933E5B6
> > 6831E929
> >  4EDE1BA8 5DF14270 FD370778 D9BE3EC6 AEE86F21 C018174F 10DF26D7
> > validating sha512... passed
> > verifying asc... passed (signed-by: Dave Grove <dgr...@apache.org>)
> > verifying notice... passed
> > verifying absence of DISCLAIMER.txt passed
> > verifying license... passed
> > verifying sources have proper headers... passed
> > scanning for executable files... passed
> > scanning for unexpected file types... passed
> > scanning for archives... passed
> > scanning for packages... passed
> > scanning package.json for version match... passed (none detected)
> > scanning package-lock.json for version match... passed (none detected)
> > removing the scratch space
> > (/var/folders/q9/s3th42s53d34ftd5wvcypybr0000gn/T/tmp.vdNrvpLr)... ok
> >
> >
> > On Tue, Aug 10, 2021 at 2:50 PM Dave Grove <dgr...@apache.org> wrote:
> >
> > > +1 to release openwhisk-runtime-nodejs 1.19.0.  Release checked with
> > > rcverify.
> > >
> > > --Dave
> > >
> > > On 2021/08/05 22:01:55, "David P Grove" <gro...@us.ibm.com> wrote:
> > > >
> > > >
> > > > Hi,
> > > >
> > > > This is a call to vote on releasing version 1.19.0 release candidate
> > rc1
> > > of
> > > > the following project module with artifacts built from the Git
> > > repositories
> > > > and commit IDs listed below.
> > > >
> > > > * OpenWhisk Runtime Node.js: 501b4c497e2c747397ba009ffa85240adecae30c
> > > >
> > > >
> > >
> >
> https://github.com/apache/openwhisk-runtime-nodejs/commit/501b4c497e2c747397ba009ffa85240adecae30c
>
> > > >
> > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/openwhisk/rc1/openwhisk-runtime-nodejs-1.19.0-sources.tar.gz
>
> > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/openwhisk/rc1/openwhisk-runtime-nodejs-1.19.0-sources.tar.gz.asc
>
> > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/openwhisk/rc1/openwhisk-runtime-nodejs-1.19.0-sources.tar.gz.sha512
>
> > > >
> > > > This release is comprised of source code distribution only.
> > > >
> > > > You can use this UNIX script to download the release and verify the
> > > > checklist below:
> > > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=openwhisk-release.git;a=blob_plain;f=tools/rcverify.sh;hb=b2f1ee4
>
> > > >
> > > > Usage:
> > > > curl -s "
> > > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=openwhisk-release.git;a=blob_plain;f=tools/rcverify.sh;hb=b2f1ee4
>
> > > > " -o rcverify.sh
> > > > chmod +x rcverify.sh
> > > > ./rcverify.sh openwhisk-runtime-nodejs 1.19.0 rc1
> > > >
> > > > Please vote to approve this release:
> > > >
> > > >   [ ] +1 Approve the release
> > > >   [ ]  0 Don't care
> > > >   [ ] -1 Don't release, because ...
> > > >
> > > > Release verification checklist for reference:
> > > >   [ ] Download links are valid.
> > > >   [ ] Checksums and PGP signatures are valid.
> > > >   [ ] Source code artifacts have correct names matching the current
> > > > release.
> > > >   [ ] LICENSE and NOTICE files are correct for each OpenWhisk
> > repository.
> > > >   [ ] All files have license headers as specified by OpenWhisk
> project
> > > > policy [1].
> > > >   [ ] No compiled archives bundled in source archive.
> > > >
> > > > This majority vote is open for at least 72 hours.
> > > >
> > > >
> > > > [1]
> > > >
> > >
> >
> https://github.com/apache/openwhisk-release/blob/master/docs/license_compliance.md
>
> > > >
> > >
> >
>
>
>
>
>

Reply via email to