Sounds good! I mentioned it on Slack too, but I'll also post it here - I have an example implementation at https://github.com/mattwelke/packt-book-bot.
- Matt On Fri, Jan 7, 2022 at 8:46 AM Rodric Rabbah <rod...@gmail.com> wrote: > Thanks for sharing this Matt - it's on my stack to look at. We should > really upgrade our Java runtime for actions. > > -r > > On Thu, Jan 6, 2022 at 1:43 AM Matt Welke <mattwe...@gmail.com> wrote: > > > I posted this on Slack. Figured it'd be nice to copy it in here too: > > > > > Hey I just realized I forgot to share this here before: > > https://github.com/ow-extended-runtimes/java-17 > > > > > > *comment from rr* > > > > > > You might remember that around June I proposed a new API for the Java > > runtime to enable us to move from Java 8 to Java 11. We ended up deciding > > it would be good to wait until we can do all runtimes so that they don't > > get inconsistent. > > > I ended up getting busy and I thought that was too ambitious so I > didn't > > return to the issue on the mailing list. No one else has yet either. But > > maybe doing just the Java runtimes (and accepting that they'd be > different > > from the other language runtimes) would be okay. If so, I'm happy to > > contribute. In the meantime, I figured I'd just make it an unofficial > thing > > for my own use, but shared in public. > > > I'm also not using the action loop intentionally because I don't think > it > > adds any performance and I think it makes things more complex for each > > runtime than they need to be. For example, because there's no action loop > > here, I don't need to worry about Python being part of the build process > or > > having a complex hierarchy of container images. It's just a Java image. > > We'd want to talk about whether actionloop would be used if I contributed > > this. > > > > Matt > > >
