Thank you for your kind review. I've applied the change you suggested. You can also leave additional comments in the feature implementation PR, and I think the POEM can be modified according to the reviews.
Best Regards. Seonghyun 2022년 5월 24일 (화) 오후 12:14, Rodric Rabbah <[email protected]>님이 작성: > Thanks - I just reviewed the proposal - nice work! > > -r > > On Wed, May 18, 2022 at 9:39 PM Dominic Kim <[email protected]> wrote: > > > Dear Rodric. > > > > You can review this proposal PR. > > https://github.com/apache/openwhisk/pull/5236 > > > > Any feedback would be really appreciated. > > I would merge this in another 2 days if there is no any comment. > > > > Thanks > > Best Regards > > Dominic > > > > > > > > > > > > [image: Mailtrack] > > < > > > https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&; > > > > > Sender > > notified by > > Mailtrack > > < > > > https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&; > > > > > 22. > > 05. 19. 오전 10:36:28 > > > > 2022년 5월 16일 (월) 오후 10:26, Rodric Rabbah <[email protected]>님이 작성: > > > > > This is a very useful feature indeed. It would help to separate the > > > proposal ( > > > > > > > > > https://github.com/apache/openwhisk/pull/5229/files?file-filters%5B%5D=.md&show-viewed-files=false > > > ) > > > from the implementation rather than combine the two into a single PR. > > I'll > > > review the proposal first. > > > > > > -r > > > > > > On Mon, May 16, 2022 at 6:03 AM Dominic Kim <[email protected]> > wrote: > > > > > > > This will enable the customization of limits for a certain namespace. > > > > We can easily adjust the limit of the namespace without affecting the > > > > others. > > > > > > > > Please review the proposal and give us your feedback. > > > > > > > > I would merge the POEM in 2 days. > > > > > > > > The implementation PR for the POEM is also open. > > > > https://github.com/apache/openwhisk/pull/5229 > > > > > > > > Any feedback would be appreciated. > > > > > > > > Kind regards > > > > Dominic > > > > > > > > > > > > > > > > > > > > > > > > 2022년 5월 16일 (월) 오후 5:42, Seonghyun Oh <[email protected]>님이 작성: > > > > > > > > > Hi, whiskers, > > > > > I've written a proposal document (POEM) about a new feature for > > > > configuring > > > > > different action limits (memory, timeout, parameter size, payload > > > size..) > > > > > settings per namespace. > > > > > > > > > > https://github.com/apache/openwhisk/pull/5236 > > > > > > > > > > Although there are no related issues in Github, we are developing > the > > > > > feature according to the needs of our users. > > > > > > > > > > I'd like to contribute this new feature to the upstream as well. > > > > > If you have any concerns, issues, or improvements in introducing > this > > > > > feature, please leave a comment. > > > > > > > > > > Best regards. > > > > > - Seonghyun > > > > > > > > > > > > > [image: Mailtrack] > > > > < > > > > > > > > > > https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&; > > > > > > > > > Sender > > > > notified by > > > > Mailtrack > > > > < > > > > > > > > > > https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&; > > > > > > > > > 22. > > > > 05. 16. 오후 07:02:39 > > > > > > > > > >
