Thanks to everyone who commented on the POEM and implementation PR for namespace-specific configuration.
I have resolved the conflict several times and am doing a rebase. I will try to pass all CI tests as soon as possible. Regards, Seonghyun 2022년 8월 5일 (금) 오전 10:19, Dominic Kim <style9...@gmail.com>님이 작성: > Thank you for the comment, Rob > > Yes, that is mandatory. I will definitely merge the PR after all tests are > passed. > As it's open for a long, it is being repeatedly outdated with other PRs > merged. > So it had passed all tests but we should rebase the code to resolve > conflicts and make it pass all tests(if there is any failure) again and > again. > That is one of the reasons that I am trying to merge it if there is no > further comment. > And it seems another great discussion is initiated thanks to Brendan. > > -dom > > > > 2022년 8월 4일 (목) 오후 6:38, Rob Allen <r...@akrabat.com>님이 작성: > > > Hey Dominic, > > > > At a high level, that change seems useful to me. I cannot comment on the > > detail of the implementation, but I’m confident in those that have > approved > > it. > > > > I think that the CI tests should pass before merging, though. > > > > Regards, > > > > Rob > > > > > On 3 Aug 2022, at 13:21, Dominic Kim <style9...@gmail.com> wrote: > > > > > > Dear whiskers. > > > > > > I am about to merge this PR [1]. > > > This is to specify a different limit with the system default for a > > certain > > > namespace. > > > With this change, we can configure a bigger limit for a certain > namespace > > > without altering the system-wide configuration that impacts all > systems. > > > It is backward-compatible. > > > > > > Since it has been open for a long time, I would merge it based on > silent > > > consent. > > > Please feel free to share your opinions and suggestions. > > > > > > [1] https://github.com/apache/openwhisk/pull/5229 > > > > >
