+1 from me.

Brendan

On Sat, Aug 12, 2023 at 5:41 PM Dominic Kim <style9...@gmail.com> wrote:

> Dear whiskers.
>
> My PR[1] fixes a critical bug that activations could be sent to a container
> belonging to the wrong namespace.
> Since this bug is critical and urgent I hope we can merge it as quickly as
> possible.
>
> But multi-runtime tests keep failing.
> I am unsure from when the regression is introduced but the tests are
> failing in the recent 3 commits in the master branch as well.
> I would look into it too but hope to merge my PR without passing the tests
> because multi-runtime tests are running against a sharding-based scheduler
> and my PR only affects the FPS scheduler.
>
> Please share your opinion.
>
> Best regards
> Dominic
>
> [1] https://github.com/apache/openwhisk/pull/5432
>

Reply via email to