[ 
https://issues.apache.org/jira/browse/OPTIQ-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040005#comment-14040005
 ] 

Julian Hyde commented on OPTIQ-306:
-----------------------------------

we should re-organize imports at the same time that we re-org package structure

> Standardize code style for "import package.*;"
> ----------------------------------------------
>
>                 Key: OPTIQ-306
>                 URL: https://issues.apache.org/jira/browse/OPTIQ-306
>             Project: optiq
>          Issue Type: Improvement
>            Reporter: Julian Hyde
>            Priority: Trivial
>
> Our house style does not specify whether/when imports are to be converted to 
> stars. I propose that imports should be converted to stars if there are more 
> than 3 from the same package. Thus:
> {code}
> import a.b.C1;
> import a.b.C2;
> import a.b.C3;
> {code}
> becomes
> {code}
> import a.b.*;
> {code}
> when {{a.b.C4}} is added. This is consistent with IntelliJ's default rule.
> It is OK to use stars if there are 3 or fewer uses. Thus removing the use of 
> {{a.b.C2}} would not require imports to be changed.
> Checkstyle has a rule to ban star imports (excluding certain packages) but 
> does not allow them to be limited to a particular number.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to