[
https://issues.apache.org/jira/browse/OPTIQ-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047184#comment-14047184
]
Vladimir Sitnikov edited comment on OPTIQ-300 at 6/29/14 5:44 PM:
------------------------------------------------------------------
{noformat}
core/src/main/java/org/eigenbase/rex/RexBuilder.java
+ final List<Integer> notNullArgList =
+ nullableArgs(aggCall.getArgList(), aggArgTypes);
{noformat}
This looks odd. Are you looking for nullable or NOT null arguments?
was (Author: vladimirsitnikov):
{noformat}
core/src/main/java/org/eigenbase/rex/RexBuilder.java
+ final List<Integer> notNullArgList =
+ nullableArgs(aggCall.getArgList(), aggArgTypes);
{noformat}
This looks odd. Are you looking for nullable or NOT null arguments?
{noformat}
core/src/main/java/org/eigenbase/sql/validate/SqlValidator.java
Util.first(Boolean.getBoolean("optiq.strict.sql"), false);
{noformat}
This is overengineering. Just use {{Boolean.getBoolean("optiq.strict.sql",
false}}
> Support multiple parameters in count(distinct col1, col2, ..)
> -------------------------------------------------------------
>
> Key: OPTIQ-300
> URL: https://issues.apache.org/jira/browse/OPTIQ-300
> Project: optiq
> Issue Type: Improvement
> Reporter: GitHub Import
> Labels: github-import
>
> Currently for sql like -- select count(distinct seller_id, lstg_format_name)
> from test_kylin_fact
> Will result --
> org.eigenbase.sql.validate.SqlValidatorException <init>
> SEVERE: org.eigenbase.sql.validate.SqlValidatorException: Invalid number of
> arguments to function 'COUNT'. Was expecting 1 arguments
> Could optiq support multiple parameters in count(distinct ...) ?
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/julianhyde/optiq/issues/300
> Created by: [liyang-gmt8|https://github.com/liyang-gmt8]
> Labels: enhancement,
> Created at: Thu Jun 12 12:00:44 CEST 2014
> State: open
--
This message was sent by Atlassian JIRA
(v6.2#6252)
