[
https://issues.apache.org/jira/browse/OPTIQ-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050811#comment-14050811
]
Julian Hyde commented on OPTIQ-327:
-----------------------------------
In cases where there is an existing JoinRel, it is better to invoke
JoinRelBase.copy. It's better than a factory. PushJoinThroughJoinRule and
SwapJoinRule already do this.
LoptOptimizeJoinRule needs to use a JoinFactory.
ExtractJoinFilterRule, PushProjectPastJoinRule, PushSemiJoinPastJoinRule need
to use JoinRelBase.copy.
Leaving RelDecorrelator, RelStructuredTypeFlattener, SqlToRelConverter as is
for now. They work in the logical domain.
> Rules should use base class to find rule match & use factory for object
> creation
> --------------------------------------------------------------------------------
>
> Key: OPTIQ-327
> URL: https://issues.apache.org/jira/browse/OPTIQ-327
> Project: Optiq
> Issue Type: Bug
> Reporter: Laljo John Pullokkaran
> Assignee: Julian Hyde
>
> Rules should use base class to find rule match; also the actual object
> creation with in rules should be using factory.
> Eg: PushJoinThroughJoin, SwapJoin rules
--
This message was sent by Atlassian JIRA
(v6.2#6252)
