+1 for RC1 - Verified build from src - Verified signature and checksum - Ran unit tests
Thanks Prasanth > On Jun 3, 2016, at 12:34 PM, Owen O'Malley <[email protected]> wrote: > > On Fri, Jun 3, 2016 at 10:57 AM, Chris Douglas <[email protected]> wrote: > >> Going through the Java dependencies, all the licensing looks good >> (tukaani:xz is public domain, Objenesis ASLv2, etc.). >> >> Should the storage API version be set as *-pre-orc? Just curious. >> <storage-api.version>2.1.0-pre-orc</storage-api.version> >> > > Yes, that is deliberate. The storage-api module is a mirror of the Hive > storage-api module on branch-2.1 and so the 2.1.0-pre-orc version string > was picked so that when Hive releases 2.1.0 maven will automatically pick > the 2.1.0 version. > > >> >> Built and ran tests for both C++/Java (all pass), NOTICE/LICENSE look >> good, except the NOTICE contains the following text: >> ---- >> This product includes software developed by Hewlett-Packard: >> (c) Copyright [2014-2015] Hewlett-Packard Development Company, L.P >> >> This product includes software developed by Hortonworks: >> (c) Copyright [2014-2015] Hortonworks, Inc. >> >> The site formatting includes software developed by Tom Preston-Werner: >> (c) Copyright [2008-2015] Tom Preston-Werner >> ---- >> >> Are there dependencies that require these? The docs for licensing [1] >> stipulate that the NOTICE should not contain any text not legally >> required. > > > I can remove the Hortonworks one, but the HP line was a condition imposed > by HP > before moving the C++ code into Apache. I'll file a jira to remove the > Hortonworks line. > > https://issues.apache.org/jira/browse/ORC-66 > > .. Owen > > >> -C >> >> [1] http://www.apache.org/dev/licensing-howto.html#mod-notice >> >> >> On Thu, Jun 2, 2016 at 3:54 PM, Matt Burgess <[email protected]> wrote: >>> I am out of town through Sunday so I won't be able to give the RC a try >> before the vote closes, but I've had a good experience with the snapshot so >> far (the Java part) so I'm looking forward to the release! >>> >>> One thing I did see, but couldn't characterize enough to file a Jira, >> was the setting of a null value into a union column. While the isNull entry >> appeared to be set correctly in memory, when i wrote the file then read it >> back in, the isNull entry was false (when it was true right before >> writing). I will dig in when I get back; so far all observed errors have >> been my own :) >>> >>> Regards, >>> Matt >>> >>>> On Jun 2, 2016, at 6:21 PM, Owen O'Malley <[email protected]> wrote: >>>> >>>> Ok, I addressed Prasanth's points and have rolled a new RC. >>>> >>>> Artifacts: http://home.apache.org/~omalley/orc-1.1.0/ >>>> Git tag: https://github.com/apache/orc/releases/tag/release-1.1.0rc1 >>>> >>>> Voting will conclude in 72 hours. >>>> >>>> Thanks, >>>> Owen
