Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/40#discussion_r69784363
  
    --- Diff: java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java ---
    @@ -201,6 +201,10 @@ public void nextVector(ColumnVector previous,
         public BitFieldReader getPresent() {
           return present;
         }
    +
    --- End diff --
    
    What do you think about moving the building of writerIncluded into the 
SchemaEvolution class? I think it would be pretty natural there and building it 
would come naturally out of buildMapping.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to