+1 on the release.

Although I still feel ORC-135 is important as the default behaviour (PPD
on) can return incorrect results for timestamp columns. Maybe we can roll
another quick release after 1.3.1 with ORC-135. This would need backport to
1.2.x that disables PPD on timestamp columns (ORC-137).


Thanks and Regards,
Prasanth Jayachandran


On Wed, Feb 1, 2017 at 11:15 AM, Alan Gates <[email protected]> wrote:

> I'm +1 to releasing, as I believe Hive 2.next will need ORC-134 and
> ORC-138.  I don't have enough information to make a call on the risk vs
> reward for ORC-135.
>
> Alan.
>
> > On Jan 31, 2017, at 9:06 AM, Owen O'Malley <[email protected]> wrote:
> >
> > All,
> >   We have a couple of bug fixes that have gone in and I think we should
> > make a release.
> >
> > Fixes:
> > * ORC-134 DecimalColumnStatistics throws NPE when all column values are
> > null.
> > * ORC-100 Make findbugs a mandatory part of the build and fixed all of
> the
> > current warnings.
> > * ORC-138 Fix forward port of HIVE-15335 that messed up schema evolution
> > for decimal.
> >
> > The other one that is pending is ORC-135 (predicate pushdown for
> timestamp
> > is sensitive to
> > changing timezones) is important, but I want to be really careful with
> that
> > one since it is a
> > larger change. I'm in the middle of reviewing that one and that one is a
> > lot riskier change.
> >
> > .. Owen
>
>

Reply via email to