Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/99#discussion_r104287854
--- Diff: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java ---
@@ -468,16 +470,15 @@ static TruthValue
evaluatePredicateRange(PredicateLeaf predicate, Object min,
}
// in case failed conversion, return the default YES_NO_NULL truth
value
} catch (Exception e) {
- if (LOG.isWarnEnabled()) {
+ if (LOG.isDebugEnabled()) {
--- End diff --
This isn't ok. We can't take exceptions and make them invisible. We need to
avoid the exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
