Github user majetideepak commented on the issue:
https://github.com/apache/orc/pull/113
@wgtmac I made some more comments. Thanks for minimizing the patches.
I learnt the following rules of thumb for C++ apache projects, which might
also help us improve the ORC C++ library significantly. I feel this is the
right opportunity to do this.
1. An implementation must follow the PIMPL idiom. The public headers must
include only the minimal API and all the class members, implementation will go
in the Impl classes.
2. We must follow a coding style. How about we pick the google C++ coding
style https://google.github.io/styleguide/cppguide.html?
3. We must try to disambiguate the class names and file names as much as
possible so that anyone new to the code base can quickly understand the code.
Let me know what your thoughts are. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
