Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/115#discussion_r114602179
--- Diff: c++/include/orc/Type.hh ---
@@ -82,6 +82,11 @@ namespace orc {
* @return a reference to the union type
*/
virtual Type* addUnionChild(ORC_UNIQUE_PTR<Type> fieldType) = 0;
+
+ /**
+ * Build a Type object from string text representation.
+ */
+ static Type* buildTypeFromString(const std::string& input);
--- End diff --
Let's make it a unique_ptr<Type> to make it clear that the caller owns the
pointer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
