With five +1's (3 binding) and no -1's the release passes. Thanks everyone! Owen
On Fri, May 5, 2017 at 4:56 PM, Prasanth Jayachandran < [email protected]> wrote: > There are rat failures in java/bench as well.. > orc-1.4.0/java/bench/fetch-data.sh > orc-1.4.0/java/bench/src/main/resources/github.schema > orc-1.4.0/java/bench/src/main/resources/log4j.properties > orc-1.4.0/java/bench/src/main/resources/sales.schema > orc-1.4.0/java/bench/src/main/resources/taxi.schema > > > Thanks and Regards, > Prasanth Jayachandran > > > On Fri, May 5, 2017 at 4:49 PM, Alan Gates <[email protected]> wrote: > > > +1. > > > > I did a build on centos and ran the unit tests. Checked the signatures > > (why is the file called .sig instead of .asc? that screwed up my release > > test script; grumble, grumble). > > > > Rat build failed. I don't think this is an issue since all of the > > unapproved files look like test results, but it would be nice to add them > > to the excludes so rat passes again. The failing files are: > > > > java/tools/src/test/resources/orc-file-dump-bloomfilter.out > > java/tools/src/test/resources/orc-file-dump-bloomfilter2.out > > java/tools/src/test/resources/orc-file-dump-dictionary-threshold.out > > java/tools/src/test/resources/orc-file-dump.json > > java/tools/src/test/resources/orc-file-dump.out > > java/tools/src/test/resources/orc-file-has-null.out > > > > Alan. > > > > On May 3, 2017, 10:13 -0700, Owen O'Malley <[email protected]>, > > wrote: > > > Ok, I made two mistakes: > > > 1. I didn't update the version in the build to say 1.4.0 instead of > > > 1.4.0-SNAPSHOT. > > > 2. I didn't include the ORC-181 fix. > > > > > > I've rolled a new release candidate. > > > > > > Tag: https://github.com/apache/orc/releases/tag/release-1.4.0rc1 > > > Tar ball: http://home.apache.org/~omalley/orc-1.4.0/ > > > > > > On Wed, May 3, 2017 at 9:13 AM, Owen O'Malley <[email protected] > > > wrote: > > > > > > > All, > > > > We've been adding some features to ORC and I'd like to make a release > > > > before we start on the refactoring of the C++ to add the writer. > > > > > > > > Tag: https://github.com/apache/orc/releases/tag/release-1.4.0rc0 > > > > Tar ball: http://home.apache.org/~omalley/orc-1.4.0/ > > > > > > > > We should probably roll a 1.3.4 also, to get some of the bug fixes > that > > > > have been going in. > > > > > > > > Thanks, > > > > Owen > > > > > > >
