Github user wgtmac commented on the issue:
https://github.com/apache/orc/pull/120
@omalley @majetideepak @xndai
As I am waiting for [PR of ORC-185](https://github.com/apache/orc/pull/116)
being resolved, I haven't added all functions that we have implemented for
column statistics to avoid huge effort for refactoring later. In this PR, I
just followed the style of current code base which puts function declaration in
the class ColumnStatistics and implements them in every ColumnStatisticsImpl
class and it contains a lot of copying and pasting duplicate code (e.g. in
c++/src/Statistics.hh). Actually in our internal implementation, we put the
implementation of functions like hasNull(), getNumberOfValues(), increase(),
merge(), reset(), etc. into the base class **ColumnStatistics**. What are your
thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
