Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/152#discussion_r132529457
  
    --- Diff: c++/src/ByteRLE.cc ---
    @@ -26,9 +26,9 @@
     
     namespace orc {
     
    -  const size_t MINIMUM_REPEAT = 3;
    -  const size_t MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
    -  const size_t MAX_LITERAL_SIZE = 128;
    +  const int MINIMUM_REPEAT = 3;
    +  const int MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
    +  const int MAX_LITERAL_SIZE = 128;
    --- End diff --
    
    I tried CentOS6 docker image. The warnings seem to be correct.
    ```
    cc1plus: warnings being treated as errors
    /root/orc/c++/src/ByteRLE.cc: In member function ‘void 
orc::ByteRleEncoderImpl::write(char)’:
    /root/orc/c++/src/ByteRLE.cc:152: error: comparison between signed and 
unsigned integer expressions
    /root/orc/c++/src/ByteRLE.cc:166: error: comparison between signed and 
unsigned integer expressions
    /root/orc/c++/src/ByteRLE.cc:167: error: comparison between signed and 
unsigned integer expressions
    /root/orc/c++/src/ByteRLE.cc:179: error: comparison between signed and 
unsigned integer expressions
    make[2]: *** [c++/src/CMakeFiles/orc.dir/ByteRLE.cc.o] Error 1
    make[1]: *** [c++/src/CMakeFiles/orc.dir/all] Error 2
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to