Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/151#discussion_r132571311
  
    --- Diff: c++/include/orc/Reader.hh ---
    @@ -288,6 +288,17 @@ namespace orc {
         virtual uint64_t getCompressionSize() const = 0;
     
         /**
    +     * Get ID of writer that generated the file.
    +     * Current availiable Orc writers:
    +     * 0 = ORC Java
    +     * 1 = ORC C++
    +     * 2 = Presto
    +     * @param id out parameter for writer id
    +     * @return true if writer id is availiable, false if otherwise
    +     */
    +    virtual bool getWriterId(uint32_t & id) const = 0;
    --- End diff --
    
    If it isn't there, it means ORC Java. Let's make an enum that matches this:
    
        enum WriterId { ORC_Java = 0, ORC_CPP = 1, ORC_Presto = 2, ORC_FUTURE = 
INT_MAX }
    
    Any unknown code should return ORC_FUTURE.
    
       virtual WriterId getWriterId() const = 0;


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to