Github user jcrist commented on the issue:

    https://github.com/apache/orc/pull/193
  
    From http://www.apache.org/dev/apply-license.html#new it looks like they 
recommend storing `LICENSE` and `NOTICE` in the root of the tar archive of a 
distribution (as you've done here). Unfortunately cpack doesn't make it easy to 
distinguish between files in `make install` and `make package`.
    
    Neither `parquet-cpp` nor `arrow` include `LICENSE` or `NOTICE` on `make 
install` or `make package` (`parquet-cpp` only, arrow doesn't use `cpack`). For 
at least the python wrappers for these libraries, the actual release artifacts 
are generated via an external tool that adds in the LICENSE stuff.
    
    This separation of build/package makes sense to me, but may not for this 
project (not sure how y'all handle releases). Perhaps the LICENSE/NOTICE could 
be added to the `tar.gz` file after `make package` manually via another make 
target? Adding to `doc/orc/{NOTICE,LICENSE}` might be equally fine? I'm not 
really sure what's best here, either is fine with me.


---

Reply via email to