Github user moresandeep commented on the issue:
https://github.com/apache/orc/pull/208
Hello @omalley
Thank you for the review !
I have incorporated most of the changes you proposed, except the one about
copying output bytes.
The thing is I will be needing another buffer for case where the
targetLength > hash.length to pad the hash with blanks. So, I am wondering if
we can keep that one as it is, I will do this in the maskBinary function where
I do not need to pad. Let me know your thoughts.
Also I have added hardened some test cases.
Thanks again.
---
