Hi all,

In ColumnReader.cc<http://ColumnReader.cc> line 108 - 113, there’s an 
incomingMask parameter that’s used to mask some of the rows in the batch when 
it’s specified. I am not sure why we would allow caller to specify a mask. If 
some of the rows are not desired, the caller can always filter them after 
getting the row batch. Passing down a mask doesn’t give any more benefits. 
Besides this parameter is always set to nullptr (see 
Reader.cc<http://Reader.cc> line 832) as far as I can tell. So it looks to me 
that we should just remove it.

Any thoughts?

Reply via email to