Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/273#discussion_r190801085
--- Diff: c++/src/RLE.hh ---
@@ -68,7 +76,24 @@ namespace orc {
* record current position
* @param recorder use the recorder to record current positions
*/
- virtual void recordPosition(PositionRecorder* recorder) const = 0;
+ virtual void recordPosition(PositionRecorder* recorder) const;
+
+ protected:
+ std::unique_ptr<BufferedOutputStream> outputStream;
+ size_t bufferPosition;
+ size_t bufferLength;
+ size_t numLiterals;
+ int64_t* literals;
+ bool isSigned;
+ char* buffer;
+
+ virtual void write(int64_t val) = 0;
+
+ virtual void writeByte(char c);
+
+ virtual void writeVulong(int64_t val);
+
+ virtual void writeVslong(int64_t val); protected:
--- End diff --
remove protected
---
