With three +1's and no -1's the vote passes. Alan, I'll fix the RAT problem by updating the exclude patterns. It shouldn't be triggering on readme files.
Thanks, Owen On Thu, May 24, 2018 at 11:51 AM, Alan Gates <ga...@apache.org> wrote: > +1. Did a build and ran the tests. Checked the signature and hash. Ran > rat, which failed, complaining about the file bench/README.md This isn't a > show stopper but would be nice to fix in the future. > > Also, the maven enforcer plugin can be used to prevent snapshots in > releases. See the Hive pom for an example. > > Alan. > > On 2018/05/23 01:49:05, "Owen O'Malley" <owen.omal...@gmail.com> wrote: > > I should also say that ORC-365 and ORC-367 are necessary for Hive to pass > > its unit tests. > > > > .. Owen > > > > On Tue, May 22, 2018 at 5:27 PM, Prasanth Jayachandran < > > j.prasant...@gmail.com> wrote: > > > > > +1 > > > - verified signature, checksum > > > - built from source > > > - ran unit tests > > > - ran orc file unit tests in hive > > > > > > Thanks and Regards, > > > Prasanth Jayachandran > > > > > > > > > > > > On Tue, May 22, 2018 at 4:32 PM Owen O'Malley <owen.omal...@gmail.com> > > > wrote: > > > > > > > All, > > > > As Prasanth noticed, I forgot to remove the SNAPSHOT from the > version. > > > > Should we release the following artifacts as ORC 1.5.1? > > > > > > > > tar: http://home.apache.org/~omalley/orc-1.5.1/ > > > > tag: https://github.com/apache/orc/releases/tag/release-1.5.1rc1 > > > > jiras: https://issues.apache.org/jira/projects/ORC/versions/ > 12343287 > > > > > > > > Thanks, > > > > Owen > > > > > > > > > >
