Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/273#discussion_r191275478
  
    --- Diff: c++/src/Writer.cc ---
    @@ -38,9 +38,10 @@ namespace orc {
         FileVersion fileVersion;
         double dictionaryKeySizeThreshold;
         bool enableIndex;
    +    RleVersion rleVersion;
     
         WriterOptionsPrivate() :
    -                            fileVersion(0, 11) { // default to Hive_0_11
    +                            fileVersion(0, 12) { // default to Hive_0_12
    --- End diff --
    
    We should use the static constants proposed in PR 
https://github.com/apache/orc/pull/274 moving forward.


---

Reply via email to